Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use i18n translations for search and sort fields #1566

Merged
merged 2 commits into from Oct 28, 2016
Merged

Use i18n translations for search and sort fields #1566

merged 2 commits into from Oct 28, 2016

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Oct 28, 2016

No description provided.

@cbeer
Copy link
Member Author

cbeer commented Oct 28, 2016

This is somewhat unsatisfying and uncovered significant opportunities for future refactoring.

@coveralls
Copy link

coveralls commented Oct 28, 2016 •
edited

Coverage Status

Coverage decreased (-0.002%) to 94.617% when pulling 530b060 on i18n-fields into c7c3329 on master.

@coveralls
Copy link

coveralls commented Oct 28, 2016 •
edited

Coverage Status

Coverage increased (+0.002%) to 94.62% when pulling 135e838 on i18n-fields into c7c3329 on master.

@jcoyne
Copy link
Member

jcoyne commented Oct 28, 2016

Can we merge #1527 first?

@coveralls
Copy link

coveralls commented Oct 28, 2016 •
edited

Coverage Status

Coverage increased (+0.002%) to 94.62% when pulling 57c6bbf on i18n-fields into c7c3329 on master.

@cbeer
Copy link
Member Author

cbeer commented Oct 28, 2016

I'd really like to get this in first, I think.. I'm optimistic it'll be an easy backport to into a 6.x release, but after #1527, I think it'll be somewhat more painful. I've added a quick refactor into this PR that may make it more appealing.

@coveralls
Copy link

coveralls commented Oct 28, 2016 •
edited

Coverage Status

Coverage increased (+0.01%) to 94.629% when pulling 02ea2e5 on i18n-fields into c7c3329 on master.

jcoyne
jcoyne approved these changes Oct 28, 2016
View reviewed changes
Copy link
Member

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sighs heavily

@jcoyne jcoyne merged commit 1cfced6 into master Oct 28, 2016
@jcoyne jcoyne deleted the i18n-fields branch October 28, 2016 18:18
@cbeer cbeer mentioned this pull request Oct 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoyne jcoyne jcoyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Blacklight 7.0 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cbeer @coveralls @jcoyne